Conversation
Yang-33
commented
Jun 20, 2026
Comment on lines
-584
to
-592
| :param grant_type: `client_credentials` (required) | ||
| :param grant_type: `client_credentials` | ||
| :type grant_type: str | ||
| :param client_assertion_type: URL-encoded value of `urn:ietf:params:oauth:client-assertion-type:jwt-bearer` (required) | ||
| :param client_assertion_type: URL-encoded value of `urn:ietf:params:oauth:client-assertion-type:jwt-bearer` | ||
| :type client_assertion_type: str | ||
| :param client_assertion: A JSON Web Token the client needs to create and sign with the private key of the Assertion Signing Key. (required) | ||
| :param client_assertion: A JSON Web Token the client needs to create and sign with the private key of the Assertion Signing Key. | ||
| :type client_assertion: str | ||
| :param client_id: Channel ID. (required) | ||
| :param client_id: Channel ID. | ||
| :type client_id: str | ||
| :param client_secret: Channel secret. (required) |
Contributor
Author
There was a problem hiding this comment.
Fix is correct. It is not required, and the previous implementation was simply incorrect.
Yang-33
commented
Jun 20, 2026
| """ | ||
| AUDIENCE_GROUP_AUDIENCE_INSUFFICIENT = 'AUDIENCE_GROUP_AUDIENCE_INSUFFICIENT' | ||
| INTERNAL_ERROR = 'INTERNAL_ERROR' | ||
| NULL = 'null' |
Contributor
Author
There was a problem hiding this comment.
Actually null as string is not returned from Messaging API.
https://developers.line.biz/en/reference/messaging-api/#get-shared-audience
openapi schema mistakenly contains this, and some sdks defines NULL as string...
line/line-openapi#124 fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost all line-bot-sdk-* uses pebble as template engine instead of mustache.
This change migrates into it, because we'd like to use same way, and pebble is richer and easier than mustache.
Main diff is
linebot/v3. There is no big impact at all.